Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heeve1
reviewed
Nov 10, 2024
Comment on lines
+50
to
+51
| MemberService memberService = new MemberService(this, null); | ||
| memberService.update(updatingMember); |
There was a problem hiding this comment.
repository의 다른 메서드와는 다르게 update는 기술 구현이 아닌 member update를 호출해주는 주체로써 역할을 하고 있습니다. 다른 find, delete, save 메서드를 보시면 요청에 따라 memberSpringJPARepository 를 이용해서 기술 구현 하는데말이죠.
위 구현은 memberService가 해야할 일을 MemberJPARepository가 떠맡은게 아닌가 싶어요
현재 MemberRepository.update를 쓰는 곳이 테스트 말고는 없군요. memberService 에서 저 Update를 호출해서 목표를 달성하도록 한번 수정해보시지요
There was a problem hiding this comment.
이 부분도 멘토링떄 답변 주신대로 수정하도록 하곘습니다 #132
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경사항