Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 테이블 생성 쿼리 작성 #30

Merged
merged 5 commits into from
Sep 28, 2024
Merged

feat: 테이블 생성 쿼리 작성 #30

merged 5 commits into from
Sep 28, 2024

Conversation

dani820
Copy link
Collaborator

@dani820 dani820 commented Sep 21, 2024

이 PR을 통해 해결하려는 문제

  • DB 테이블 생성

추가 및 변경사항

  • DB 테이블 생성 위한 쿼리문 작성

참고(옵션)

체크리스트

  • 리뷰어를 지정하였는가
  • 코드가 오류나 경고없이 빌드되는가
  • 추가 및 변경된 사항에 대해 충분히 테스트 하였는가

@dani820 dani820 self-assigned this Sep 21, 2024
@dani820 dani820 marked this pull request as draft September 21, 2024 14:32
@dani820 dani820 marked this pull request as ready for review September 22, 2024 02:58
f-lab-bradley
f-lab-bradley reviewed Sep 22, 2024
View reviewed changes
Copy link
Collaborator

@f-lab-bradley f-lab-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alter Table 을 따로 적어 적용 시킨 이유가 있을까요??
Create table 에 포함 될 수 있는 내용들 같아서요.

@dani820
Copy link
Collaborator Author

dani820 commented Sep 23, 2024

아뇨 좀 더 정리해보겠습니다!

@f-lab-bradley
Copy link
Collaborator

아뇨 좀 더 정리해보겠습니다!

작성 중 이면 draft 로 PR 을 바꿔주세요

@dani820
Copy link
Collaborator Author

dani820 commented Sep 23, 2024

넵~ 작성 완료했습니다!

f-lab-bradley
f-lab-bradley approved these changes Sep 28, 2024
View reviewed changes
Copy link
Collaborator

@f-lab-bradley f-lab-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당~~
제가 추가 수정 된걸 확인이 늦었네요 ㅠㅠ 죄송해요

@dani820 dani820 merged commit e083b2e into develop Sep 28, 2024
1 check passed
@dani820 dani820 deleted the feature/29 branch September 28, 2024 14:33
@dani820 dani820 changed the title feature: 테이블 생성 쿼리 작성 feat: 테이블 생성 쿼리 작성 Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-lab-bradley f-lab-bradley f-lab-bradley approved these changes

Assignees

@dani820 dani820

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dani820 @f-lab-bradley