Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: 독서 시작일, 종료일 변수명 변경 #23

Merged
merged 1 commit into from
Sep 15, 2024
Merged

refactor: 독서 시작일, 종료일 변수명 변경 #23

merged 1 commit into from
Sep 15, 2024

Conversation

dani820
Copy link
Collaborator

@dani820 dani820 commented Sep 14, 2024

이 PR을 통해 해결하려는 문제

  • 변수명을 명확히 하여 한 눈에 의미를 파악할 수 있도록 변경

추가 및 변경사항

  • 도메인 엔티티, dto, 테스트 코드 등에서 사용되는 독서 시작일(fromDate), 독서 종료일(toDate) 변수명 변경
  • fromDate -> readingStartDate, toDate -> readingEndDate 로 변경

참고(옵션)

체크리스트

  • 리뷰어를 지정하였는가
  • 코드가 오류나 경고없이 빌드되는가
  • 추가 및 변경된 사항에 대해 충분히 테스트 하였는가

@dani820
refactor: 독서 시작일, 종료일 변수명 변경
f320080 
fromDate -> readingStartDate
toDate -> readingEndDate
@dani820 dani820 self-assigned this Sep 14, 2024
f-lab-bradley
f-lab-bradley approved these changes Sep 14, 2024
View reviewed changes
Copy link
Collaborator

@f-lab-bradley f-lab-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

훨씬 명확해 진 것 같네요.
수고 하셨습니다 ㅎㅎ

@dani820 dani820 merged commit ea2702e into develop Sep 15, 2024
1 check passed
@dani820 dani820 deleted the refactor/22 branch September 15, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@f-lab-bradley f-lab-bradley f-lab-bradley approved these changes

Assignees

@dani820 dani820

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dani820 @f-lab-bradley