feat: 독서록 조회 기능 컨트롤러 로직 작성 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
컨트롤러 로직 작성 및 테스트 코드 작성
| public record ContentResponse( | ||
| String title, | ||
| String content, | ||
| String fromDate, |
There was a problem hiding this comment.
fromDate, toDate 가 무슨 뜻인가요???
There was a problem hiding this comment.
독서 기간에 대한 변수로 각각 시작일, 종료일을 뜻하는데요. startDate, endDate로 변경하는 쪽이 더 의미가 맞다고 생각되어서 수정하려 합니다.
| import com.inmybook.application.port.in.RegisterPostCommand; | ||
| import com.inmybook.application.service.PostDetailsOutput; | ||
|
|
||
| @Component | ||
| public class PostMapper { |
There was a problem hiding this comment.
Mapper 는 왜 component 로 주입 하나요???
There was a problem hiding this comment.
작성 당시 단순히 빈 등록을 위해 @component를 사용했던 것 같습니다; 주입 방식을 달리 하는게 좋을까요?
There was a problem hiding this comment.
static 함수로 만드는 방법도 고려해 보시면 좋을것 같아요.
fromDate -> readingStartDate toDate -> readingEndDate
| @@ -31,7 +31,7 @@ public class PostController { | |||
|
|
|||
| private final RegisterPostUseCase registerPostUseCase; | |||
| private final ReadPostUseCase readPostUseCase; | |||
| private final PostMapper postMapper; | |||
| private static final PostMapper postMapper = new PostMapper(); | |||
There was a problem hiding this comment.
객체 자체를 스태틱으로 선언 하는것 외에도 PostMapper 에서 제공하는 함수를 static 함수로 만드는걸 고려해 봐도 좋을 것 같아요.
객체로 따로 만들 필요가 없어 보이는 클래스처럼 보이긴 해서요
There was a problem hiding this comment.
static 함수로 변경했습니다~
- PostMapper 클래스 내 함수들을 static으로 변경하여 불필요한 객체 생성 없이 간단히 접근 가능하도록 수정 - 조회 기능 Controller 테스트 코드 내에서 PostMapper 함수 모킹한 부분 수정(mockStatic 사용)
|
넵 피드백 주신 부분 반영 완료했습니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이 PR을 통해 해결하려는 문제
추가 및 변경사항
참고(옵션)
체크리스트