Skip to content

Commit

Permalink
refactor: memberNo 삭제 및 영향 범위 수정
Browse files Browse the repository at this point in the history
  • Loading branch information
dani820 committed Sep 20, 2024
1 parent 380dddb commit f5fc15d
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

@Builder
public record MemberDetailsOutput(
Long memberNo,
String memberId,
String nickname
) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,17 +30,14 @@ public PostDetailsOutput findPostById(ReadPostInput readPostInput) {
.build();

MemberDetailsOutput memberDetailsOutput = MemberDetailsOutput.builder()
.memberNo(post.getMember().getMemberNo())
.memberId(post.getMember().getMemberId())
.nickname(post.getMember().getNickname())
.build();

PostDetailsOutput postDetailsOutput = PostDetailsOutput.builder()
return PostDetailsOutput.builder()
.postId(post.getPostId())
.contentDetailsOutput(contentDetailsOutput)
.memberDetailsOutput(memberDetailsOutput)
.build();

return postDetailsOutput;
}
}
1 change: 0 additions & 1 deletion src/main/java/com/inmybook/domain/member/Member.java
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
@Getter
@Builder
public class Member {
private Long memberNo;
private String memberId;
private String nickname;
private String email;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,17 @@ void init() {
Content content = Content.builder()
.title("HTTP 완벽 가이드 독서록")
.content("유익합니다.")
.fromDate("2024-07-14")
.toDate("2024-07-21")
.readingStartDate("2024-07-14")
.readingEndDate("2024-07-21")
.rating(4.5)
.likeCount(0)
.bookmarkCount(0)
.isPublic("Y")
.build();

String memberId = getUuid();
Member member = Member.builder()
.email("[email protected]")
.memberId(memberId)
.nickname("dani")
.build();

Expand All @@ -73,7 +74,7 @@ void findPostById() {

assertThat(post).isNotNull();
assertThat(post.getContent().getTitle()).isEqualTo("HTTP 완벽 가이드 독서록");
assertThat(post.getMember().getEmail()).isEqualTo("[email protected]");
assertThat(post.getMember().getNickname()).isEqualTo("dani");
}

@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,9 @@ void readPost() {
.isPublic("Y")
.build();

String memberId = getUuid();
Member member = Member.builder()
.email("[email protected]")
.memberId(memberId)
.nickname("dani")
.build();

Expand Down

0 comments on commit f5fc15d

Please sign in to comment.