Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(feature-flags): use flipt as feature flag service #486

Merged
merged 15 commits into from
Oct 29, 2024
Merged

feat(feature-flags): use flipt as feature flag service #486

merged 15 commits into from
Oct 29, 2024

Conversation

nimdanitro
Copy link
Member

@nimdanitro nimdanitro commented Oct 28, 2024 •
edited
Loading

Details:

  • use flipt.sitrep.ch as feature flag service, admin access is possible with f-eld account, but instance is readonly.
  • properly setup and use flipt with openfeatureflags abstractions
  • setup CICD tasks to build and push feature flag config to allow gitops workflow for featureflags
  • ui/features.yaml is authoritative for the namespace sitrep-ui and all feature flags for frontend should be tracked here.

image

@nimdanitro nimdanitro self-assigned this Oct 28, 2024
@github-actions github-actions bot added the feat label Oct 28, 2024
@nimdanitro nimdanitro marked this pull request as ready for review October 28, 2024 19:51
@nimdanitro nimdanitro requested review from a team as code owners October 28, 2024 19:51
@nimdanitro nimdanitro merged commit fad5799 into develop Oct 29, 2024
7 checks passed
@nimdanitro nimdanitro deleted the feat/feature-flags branch October 29, 2024 08:10
lukastresch
lukastresch reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@lukastresch lukastresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work @nimdanitro! 💪🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukastresch lukastresch lukastresch left review comments

Assignees

@nimdanitro nimdanitro

Labels
feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nimdanitro @lukastresch