-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Github Integration using Github Actions #528
base: master
Are you sure you want to change the base?
Conversation
You imply a lot of questions here on future use of Launchpad and use of docker, so in general I think:
Up to Engineering here, but I would guess we in general are +1 on looking toward Github Actions, but maybe we should not mix launchpad into that question at first? Aslo if we move to Github Actions, we'd likely want to do it across all branches and repos. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, we need to explore this deeper before we decide to move this direction. It's definitely worth looking into (cc @mnocon).
The main issue I see now is that we use enterprise version of Travis which gives us better support and job debugging capabilities. Not sure if GH actions offer this on the same level w/o a need for plan upgrade.
But really reviewed because of other things ;)
| Q | A | ||
| ------------- | --- | ||
| Branch? | master / x.y.z | ||
| Bug fix? | yes/no | ||
| New feature? | yes/no <!-- don't forget updating docs/CHANGELOG.md files --> | ||
| BC breaks? | yes/no | ||
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | ||
|
||
<!-- | ||
- Please fill in this template according to the PR you're about to submit. | ||
- Replace this comment by a description of what your PR is solving. | ||
--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're aiming to unify it accross all the repositories. The latest version I've come up with is here, but still requires some debate probably, since I've pushed this during the 3.0 release rush.
| Q | A | ||
| ---------------- | ----- | ||
| Bug report? | yes/no | ||
| Feature request? | yes/no | ||
| BC Break report? | yes/no | ||
| RFC? | yes/no | ||
| Version | x.y.z | ||
| Environment | Linux/Mac/Windows | ||
|
||
|
||
<!-- | ||
- Please fill in this template according to your issue. | ||
- And replace this comment by the description of your issue. | ||
--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not relevant for us, we don't support Issues (see that the tab is missing). All the issues should be reported in JIRA.
Motivation
I have done this experiment, for 3 reasons:
.env
later. Because it contains too much configuration unrelated to the applicationIn Bonus, I figured that it would be awesome to actually test eZ Platform with Varnish and Redis through eZ Launchpad!
That would make so much sense.
Then I have initiated it.
I took some liberties for now:
Questions
vhost.sh
script. (unsure)varnish.vcl
coming fromhttp-cache bundle
. (this one I am pretty sure)Todos
ez create
instead ofinit
fail-fast: false
What do you think? what is all that stuff regarding Docker in the repo?
I am sure it is all very interesting and that could benefit eZ Launchpad and vice-versa.
But I have never ever used what you have in the
docker
folder, where do you use it? internally?I'll continue on making test works tonight,
Ping @andrerom, @bdunogier, @lserwatka @SylvainGuittard
https://github.com/Plopix/ezplatform/actions
Let me know!