-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL query support for ezxmltext field type #111
base: 1.9
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, besides the remark on the setting.
@bdunogier I have addressed your change request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@bdunogier : Can you confirm your initial remark is resolved
@bdunogier any reason not to approve and merge this PR? |
@dfritschy Could you rebase the work on latests 1.9 so we can verify that the tests passes? |
@andrerom Rebased the pull request on latest 1.9, see no connection of the failing tests with my code |
All good from my side, thank you @dfritschy ! |
@dfritschy Sorry, but the failure seems to be relevant:
|
1.9
This PR provides full GraphQL query support for
ezxmltext
field types.Modelled after the richtext field type, it offers these subtypes:
Note: mutations are not in the scope of this PR and are not a planned feature.