Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL query support for ezxmltext field type #111

Open
wants to merge 3 commits into
base: 1.9
Choose a base branch
from

Conversation

dfritschy
Copy link

Question Answer
JIRA issue none
Type Feature
Target version latest stable 1.9
BC breaks no
Doc needed no

This PR provides full GraphQL query support for ezxmltext field types.

Modelled after the richtext field type, it offers these subtypes:

  text:
        type: "String"
        description: "String representation of the value"
    xml:
        type: "String"
        description: "The raw ezxmltext xml"
    plaintext:
        type: "String"
        description: "Plain text representation of the value, without tags. Warning: the text representation may not be perfect."
    html5:
        type: "String"
        description: "HTML5 representation."

Note: mutations are not in the scope of this PR and are not a planned feature.

Copy link
Member

@bdunogier bdunogier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, besides the remark on the setting.

bundle/Resources/config/default_settings.yml Outdated Show resolved Hide resolved
@dfritschy dfritschy changed the title GraphQL query support for ezxml field type GraphQL query support for ezxmltext field type Oct 24, 2019
@dfritschy
Copy link
Author

@bdunogier I have addressed your change request.

@dfritschy dfritschy requested a review from bdunogier November 4, 2019 15:52
@vidarl vidarl self-requested a review November 7, 2019 13:25
Copy link
Member

@vidarl vidarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
@bdunogier : Can you confirm your initial remark is resolved

@dfritschy
Copy link
Author

@bdunogier any reason not to approve and merge this PR?

@andrerom
Copy link
Contributor

@dfritschy Could you rebase the work on latests 1.9 so we can verify that the tests passes?

@dfritschy
Copy link
Author

@andrerom Rebased the pull request on latest 1.9, see no connection of the failing tests with my code

@bdunogier
Copy link
Member

All good from my side, thank you @dfritschy !

@andrerom andrerom mentioned this pull request Dec 12, 2019
@andrerom
Copy link
Contributor

andrerom commented Dec 12, 2019

@dfritschy Sorry, but the failure seems to be relevant:

Exception: Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: The service "ezxmltext.graphql.resolver" has a dependency on a non-existent service "ezpublish.fieldType.ezxmltext.converter.html5". in /home/travis/build/ezsystems/ezplatform-xmltext-fieldtype/vendor/symfony/symfony/src/Symfony/Component/DependencyInjection/Compiler/CheckExceptionOnInvalidReferenceBehaviorPass.php:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants