IBX-8378: Fixed handling non-indexable field types #250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making a custom field type, it must implement Indexable (even though the field content should not be searchable) or else the solr bundle will return exception:
Legacy search and Elastic search will not throw any errors.
It is a bit unclear to me if it is intended that all fieldtypes must implement Indexable or not.
pro:
cons:
So either documentation should be updated or Solr bundle should behave as the other search engine adapters. This PR adds support in Solr for not having to implement Indexable