Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ez_http_tag_location #143

Open
wants to merge 4 commits into
base: 2.3
Choose a base branch
from
Open

Conversation

adriendupuis
Copy link
Contributor

@adriendupuis adriendupuis commented Jan 29, 2021

Question Answer
JIRA issue N/A
Type Improvement/Misc
Target version master
BC breaks no
Doc needed ibexa/documentation-developer#1297

Mark ez_http_tag_location as deprecated and ez_http_cache_tag_location as its alternative. If 2.5 BC is “to be cleaned up”, one should be informed to not using this and replace it.

TODO:

  • Implement feature / fix a bug.
  • Implement tests + specs and passing ($ composer test)
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

Mark ez_http_cache_tag_location as deprecated and ez_http_cache_tag_location as its alternative.
src/Twig/ContentTaggingExtension.php Outdated Show resolved Hide resolved
Add ez_http_cache_tag_relation_ids and ez_http_cache_tag_relation_location_ids along ez_http_cache_tag_location for consistency.

Deprecate all
@vidarl
Copy link
Member

vidarl commented Feb 9, 2021

@lserwatka So, this will be deprecated in 4.0 then (and possibly removed in 5.0) ?

@lserwatka
Copy link
Member

This is already deprecated, we need to add a note in 3.3 and remove it in 4.0 as discussed offline.

@adamwojs
Copy link
Member

@adriendupuis CI is reporting that code style needs to be fixed here. Could you please run composer fix-cs command, and then commit and push it's result? Thank you in advance,

@dabrt
Copy link

dabrt commented Feb 11, 2021

Dear gentlemen, when exactly were the two functions deprecated?
I mean ez_http_tag_relation_ids() and ez_http_tag_relation_location_ids()
Was it starting from 3.0 or 3.3?

@vidarl
Copy link
Member

vidarl commented Feb 11, 2021

Communication wise, these were deprecated in 3.3.0
Technically, they will be deprecated in 3.3.2 ( if this PR gets merged by then )

@vidarl
Copy link
Member

vidarl commented Mar 5, 2021

@adamwojs : ready for merge, right?

@sonarcloud
Copy link

sonarcloud bot commented Jul 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ibexa-yuna ibexa-yuna changed the base branch from master to 2.3 November 19, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants