Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5888: Verification of whether the given landingPage field value is correct has been changed #29

Merged
merged 5 commits into from
Aug 1, 2023
Merged

IBX-5888: Verification of whether the given landingPage field value is correct has been changed #29

merged 5 commits into from
Aug 1, 2023

Conversation

mateuszdebinski
Copy link
Contributor

Jira: https://issues.ibexa.co/browse/IBX-5888.

for tests to pass to CI (if they are connected), we need to add a dependency for landing page field type on the fly

@mateuszdebinski mateuszdebinski added bug Something isn't working Ready for review labels Jun 30, 2023
@mateuszdebinski mateuszdebinski requested a review from a team June 30, 2023 08:35
@mateuszdebinski mateuszdebinski self-assigned this Jun 30, 2023
@mateuszdebinski mateuszdebinski requested review from webhdx and a team July 20, 2023 08:25
@konradoboza konradoboza requested review from a team and ciastektk July 28, 2023 06:57
@konradoboza konradoboza requested a review from a team July 28, 2023 07:20
webhdx
webhdx suggested changes Jul 31, 2023
View reviewed changes
Copy link

@webhdx webhdx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my other comment. There seems to be a bug in PageBuilderFieldEncoder::canDecode.

Given how it is designed we cannot rely on is_a. Your proposition is okay. Sorry for the hassle.

@mnocon mnocon self-assigned this Jul 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

mnocon
mnocon approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Tested with ezstring and ezrichtext fields ✅
  • Tested with code and text Page Builder blocks ✅

QA Approved!

@konradoboza konradoboza merged commit 13b3089 into master Aug 1, 2023
4 checks passed
@konradoboza konradoboza deleted the IBX-5888_page_builder_block_is_not_translated branch August 1, 2023 09:54
@mateuszdebinski mateuszdebinski mentioned this pull request Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@mnocon mnocon mnocon approved these changes

@webhdx webhdx webhdx approved these changes

@kisztof kisztof kisztof approved these changes

@ciastektk ciastektk Awaiting requested review from ciastektk

Assignees

@ciastektk ciastektk

@mnocon mnocon

@konradoboza konradoboza

@mateuszdebinski mateuszdebinski

Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mateuszdebinski @kisztof @webhdx @mnocon @konradoboza @ciastektk