Fixing unit tests #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ests still fail though
|
Okay for me. Any objection, anyone ? @dpobel ? @paulborgermans ? |
|
+1 |
|
Fine for me |
|
Schön :) |
|
+1, thanks @pkamps, I was just scratching my head during the setup of a testing environment :). |
| @@ -33,7 +33,7 @@ public function testGetClassAttributes() | |||
| { | |||
| // echo "DB: " . eZDB::instance()->DB . "\n"; | |||
| // xdebug_print_function_stack(); | |||
|
|
|||
| //self::$qb->getClassAttributes(); die('d'); | |||
There was a problem hiding this comment.
Remove this and we are ready to go :)
|
Hi @pkamps, could you please rebase your patch serie ? Because some parts have already been fixed in HEAD. |
|
My current work load won't allow me to do this in the next 3 weeks. |
The table 'ezfind_elevate_configuration' is already created in the setUp() method of the eZ Find Test Suite
…_sql_data EZP-21779: Removed duplicate table creation
Implement EZP-21380: 'highlighting' as a SearchExtras attribute
Implement EZP-21404: Allow excluding object owner/author from search
Fix EZP-21331: fatal error due to invalid facet def passed to fetch function
…ed-results Fixed EZP-23407: an additional boolean is added in the output result set...
…ests still fail though
|
I rebased but I'm not sure if it's still a valid pull request. |
|
@pkamps Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing fatal errors in unit tests. Fixing most failing tests - some tests still fail though