Skip to content

Commit

Permalink
Merge pull request crossplane#4618 from jeanduplessis/update_controll…
Browse files Browse the repository at this point in the history
…erconfig_deprecation_warning

Further clarifies ControllerConfig deprecation
  • Loading branch information
phisco authored Sep 14, 2023
2 parents 9e25352 + be9c786 commit 6c5d2bb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion apis/pkg/v1alpha1/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ type PodObjectMeta struct {
// https://github.com/crossplane/crossplane/issues/3601 for more information.
// +kubebuilder:printcolumn:name="AGE",type="date",JSONPath=".metadata.creationTimestamp"
// +kubebuilder:resource:scope=Cluster
// +kubebuilder:deprecatedversion:warning="ControllerConfig.pkg.crossplane.io/v1alpha1 has been deprecated and will be removed in a future release, but only after a comparable alternative is available."
// +kubebuilder:deprecatedversion:warning="ControllerConfig.pkg.crossplane.io/v1alpha1 is deprecated. It is safe to use, but no new features will be added. Future replacement design: https://github.com/crossplane/crossplane/blob/master/design/one-pager-package-runtime-config.md"
type ControllerConfig struct {
metav1.TypeMeta `json:",inline"`
metav1.ObjectMeta `json:"metadata,omitempty"`
Expand Down
6 changes: 3 additions & 3 deletions cluster/crds/pkg.crossplane.io_controllerconfigs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@ spec:
name: AGE
type: date
deprecated: true
deprecationWarning: ControllerConfig.pkg.crossplane.io/v1alpha1 has been deprecated
and will be removed in a future release, but only after a comparable alternative
is available.
deprecationWarning: 'ControllerConfig.pkg.crossplane.io/v1alpha1 is deprecated.
It is safe to use, but no new features will be added. Future replacement design:
https://github.com/crossplane/crossplane/blob/master/design/one-pager-package-runtime-config.md'
name: v1alpha1
schema:
openAPIV3Schema:
Expand Down

0 comments on commit 6c5d2bb

Please sign in to comment.