Holidayで自動テストの活用方法を検討し追加する #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiyohome
requested changes
May 21, 2023
| @@ -0,0 +1,38 @@ | |||
| { | |||
| "name": "Extreal.SampleApp.Holiday.Tests", | |||
There was a problem hiding this comment.
Holiday.TestsにPerformanceTestと今回のテストをまとめた方がAssets直下のディレクトリが増えなくて、全体を理解しやすそうと感じました。
|
|
||
| namespace Extreal.SampleApp.Holiday.Tests | ||
| { | ||
| public class GoldenPath |
There was a problem hiding this comment.
機能テストに合わせてるのであればそういうクラス名にした方が追跡しやすいと思います。
| "com.unity.ide.visualstudio": "2.0.17", | ||
| "com.unity.ide.vscode": "1.2.5", | ||
| "com.unity.inputsystem": "1.5.0", | ||
| "com.unity.mobile.android-logcat": "1.3.2", | ||
| "com.unity.render-pipelines.universal": "12.1.10", | ||
| "com.unity.test-framework": "1.3.0", | ||
| "com.unity.testtools.codecoverage": "1.2.2", | ||
| "com.unity.testtools.codecoverage": "1.1.1", |
There was a problem hiding this comment.
unityのcode coverage、1.2.3でやっとgeneric typeのバグ治ったので上げても大丈夫かもしれないです。
https://docs.unity3d.com/Packages/[email protected]/changelog/CHANGELOG.html
| [UnityTest] | ||
| public IEnumerator GoldenPathTest() => UniTask.ToCoroutine(async () => | ||
| { | ||
| // Loads application |
There was a problem hiding this comment.
コメントとLoggerで同じ内容を書いているので、コメントは削除してよいと思います。
| Logger.LogInfo("Inputs player name"); | ||
| var playerNameInputField = FindObjectOfTypeAndAssert<TMP_InputField>(); | ||
|
|
||
| playerNameInputField.Select(); |
There was a problem hiding this comment.
全体的にユーザー操作がイメージできるような抽象度になってないので、理解とメンテ負荷が高いように思います。
|
|
||
| // Starts to download data and enters AvatarSelectionScreen | ||
| Logger.LogInfo("Starts to download data and enters AvatarSelectionScreen"); | ||
| titleGoButton.onClick.Invoke(); |
There was a problem hiding this comment.
今どのステージのどのシーンが対象なのか分かるような書き方にできないかな、と思いました。
さらに操作対象のステージやシーンのアサートも合った方がいいと思います。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
何の変更を加えましたか？
何を確認しましたか?
実装
テスト
テスト用のコード改変なので以下は対象外。
変更影響
レビュアーへのメッセージ