Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve pull request discovery #1

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sasjo
Copy link

@sasjo sasjo commented Nov 15, 2024

Pull Request Details

Improve pull request discovery to support push workflows.

Description

PR mode and PR comments requires a pull request or issue number to be included with the event that triggers the workflow. This only applies to pull_request workflows and not the push workflow.

This change uses Octokit to find pull requests from the branch reference when no pull_request event is available. The PR resolution means we can support pr-mode and post-pr-comment from push workflows if a pull request exists for the branch.

Related Issue

Motivation and Context

Our organization is transitioning from SonarCloud to Qodana. Our workflows are running on push events and we're accustomed to pull requests being found and commented on automatically.

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

@sasjo sasjo changed the title feat: Improve issue number discovery feat: Improve pull request discovery Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant