Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Establish basic compatibility for TYPO3 v11 #27

Open
wants to merge 3 commits into
base: 5.x
Choose a base branch
from

Conversation

krausandre
Copy link
Contributor

I've done some basic stuff to make this extension usable with TYPO3 v11.5 and EXT:cart v.8.2.0.
(I had to add a version to composer.json, otherwise I could't use it.)

Testet with:

  • PayPal sandbox
  • PHP 7.4.
  • TYPO3 11.5.6
  • EXT:cart 8.2.0
  • EXT:cart_products 4.0.3

extcode pushed a commit that referenced this pull request May 17, 2022
extcode pushed a commit that referenced this pull request May 17, 2022
extcode added a commit that referenced this pull request May 17, 2022
@extcode
Copy link
Owner

extcode commented May 17, 2022

Hi, I merged your code locally, because it has to be merged to the main branch.
I changed your first commit a little bit.

@krausandre
Copy link
Contributor Author

Okay, that's cool. So we can close this pull request if you want?

@extcode
Copy link
Owner

extcode commented May 18, 2022

I have to revert the changes in PaymentController because $this->htmlResponse()->withStatus() is not available in TYPO3 v10.

extcode added a commit that referenced this pull request May 18, 2022
@krausandre
Copy link
Contributor Author

krausandre commented May 24, 2022

So you suggest to turn off the deprecation log on each system, which uses the cart_paypal extension?
Well, this solution will work for now, but in v12 this will stuck in errors messages:
Deprecation: #92784 - Extbase controller actions must return ResponseInterface

@extcode
Copy link
Owner

extcode commented May 24, 2022

Yes, the deprecation log should always be turned off in the live system. But in TYPO3 v11 $this->htmlResponse()->withStatus() should always be used, because $this->response is not set.

The next major version is compatible to TYPO3 v11 and v12. So the next version will always use the $this->htmlResponse()->withStatus() and will always return an ResponseInterface. I don't see a problem here, do you?

@krausandre
Copy link
Contributor Author

OK I got it. I'm fine with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants