Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Cleanup type hint in class properties #585

Merged
merged 2 commits into from
Oct 16, 2024
Merged

[TASK] Cleanup type hint in class properties #585

merged 2 commits into from
Oct 16, 2024

Conversation

extcode
Copy link
Owner

@extcode extcode commented Oct 14, 2024

No description provided.

@extcode extcode requested a review from rintisch October 14, 2024 19:42
@extcode extcode self-assigned this Oct 14, 2024
rintisch
rintisch reviewed Oct 15, 2024
View reviewed changes
Copy link
Collaborator

@rintisch rintisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you search in the Classes directory for '@var' and '* @param'? There a few more type hints in comments. But I think rector should solve this as well!?

@rintisch rintisch mentioned this pull request Oct 15, 2024
Merged
@extcode extcode force-pushed the task/cleanup_type_hint_in_class_properties branch from fb44159 to f88f5dc Compare October 15, 2024 21:03
@extcode
Copy link
Owner Author

extcode commented Oct 15, 2024

I've found and replaces some more places.
The remaining positions are either

  • predefined by the parent classes (from the core) and can only be defined via annotations, or
  • they are arrays or ObjectStorages that can only be specified more precisely via annotations, or
  • a few to ensure understanding.

@extcode extcode merged commit 56fe34c into main Oct 16, 2024
11 checks passed
@extcode extcode deleted the task/cleanup_type_hint_in_class_properties branch October 16, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rintisch rintisch rintisch approved these changes

Assignees

@extcode extcode

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@extcode @rintisch