Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve and document JS custom events #453

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

rintisch
Copy link
Collaborator

Improve the DX with JS custom events and document them.

Improve developer experience by moving the prefix
`extcode:` of the custom events directly to the
event. This makes it easier to find them in the
code.
@rintisch rintisch requested a review from extcode March 22, 2024 08:47
@rintisch rintisch self-assigned this Mar 22, 2024
Describe the given JS custom events by
listing the given events and how to listen
to them.
@rintisch rintisch force-pushed the docs/documentate-js-hooks branch from b92209d to 687d4d2 Compare March 22, 2024 08:49
Copy link
Owner

@extcode extcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked at the changes, but not tested them. Looks good so far.

@extcode extcode merged commit f09d45f into extcode:main Mar 22, 2024
8 checks passed
@rintisch rintisch deleted the docs/documentate-js-hooks branch March 23, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants