fix: possible wrong ternimate rating parsing condition

exqt · Dec 14, 2024 · 435f734 · 435f734
1 parent 7f62013
commit 435f734
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "donder-hiroba-plus",
   "private": true,
-  "version": "0.2.9.2",
+  "version": "0.2.9.3",
   "type": "module",
   "scripts": {
     "dev": "vite dev",

diff --git a/src/components/Rating/RatingApp.svelte b/src/components/Rating/RatingApp.svelte
@@ -192,13 +192,18 @@
             const nextPage = await getRecentScoreData(complete + 1)
 
             // termniate condtion 1: no more data
+            let allSame = true
             for (let i = 0; i < nextPage.length; i++) {
-              if (nextPage[i].songName === firstPage[i].songName &&
-                nextPage[i].difficulty === firstPage[i].difficulty
+              if (nextPage[i].songName !== firstPage[i].songName ||
+                nextPage[i].difficulty !== firstPage[i].difficulty
               ) {
-                shouldStop = true
+                allSame = false
+                break
               }
             }
+            if (allSame) {
+              shouldStop = true
+            }
 
             // termniate condtion 2: no more plays
             for (const item of nextPage) {