Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add middleware scaffold #33

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Conversation

juliano-soares
Copy link
Member

Pull Request Guidelines

Our guidelines for submitting a pull request.

Before submitting a Pull Request, please make sure you have verified the following:

  • A good commit message should be two things: meaningful and concise. It should not contain every single detail, describing each changed line—we can see all the changes in Git—but, at the same time, it should say enough to avoid ambiguity.
  • We use Microverse's commit message convention
  • The convention stablish that a commit message has to be in the present tense, imperative and lowercase.
  • Example: fix typo in README.md
  • The commit message follows our guidelines:
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Currently the CLI does not have a command to create the Middleware Scaffold

Issue Number: #32

What is the new behavior?

A new command has been added to create the middleware scaffold, the command "expressots g m myMiddleware". The existing command to create a module has been changed from "expressots g m myModule" to "expressots g mo myModule".

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications below.

Other information

Any other information that is important to this PR.

@juliano-soares juliano-soares requested a review from rsaz March 19, 2024 22:29
@juliano-soares juliano-soares self-assigned this Mar 19, 2024
@rsaz rsaz added the enhancement New feature or request label Mar 22, 2024
@rsaz rsaz merged commit a4d2992 into main Mar 22, 2024
1 check passed
@rsaz rsaz deleted the feature/32-create-middleware-scaffold branch March 22, 2024 02:27
@rsaz rsaz mentioned this pull request Mar 30, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants