-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/experimetal transpile with swc #18
Feat/experimetal transpile with swc #18
Conversation
5198fcd
to
c37ca63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great work, loved the refactor of the templates-list.ts
, well done!
As soon as @juliano-soares approve it, @rsaz may test it on Windows and merge. |
…swc transpile system
…or interactive choices - add template types and enum - add conditional template selection - fix src/new/cli.ts bad eol
2b45438
to
b86b598
Compare
We are currently using tsx and tsc combined. With SWC we had few issues with compatibility, and didn't worth to fix as tsx + tsc deliver a good performance for the current system. |
Pull Request Guidelines
Our guidelines for submitting a pull request.
Before submitting a Pull Request, please make sure you have verified the following:
fix typo in README.md
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Please describe the current behavior that you are modifying, or link to a relevant issue.
Issue Number: N/A
What is the new behavior?
Describe the new behavior or link to a relevant issue.
Does this PR introduce a breaking change?
If this PR contains a breaking change, please describe the impact and migration path for existing applications below.
Other information
Added experimental flag for templates (see: #17)
An interactive stdout example:
Added cli commands:
This pull request moves the dependencies that used to be in the templates to the CLI, making it essential for the build.
This change simplifies the installation and maintenance of the templates, as they no longer need to have the same dependencies as the CLI. It also allows the CLI to have more control over the build process and use different tools for different tasks.
The pull request adds new dependencies to the expressots-cli package.json file:
It also adds a new dev dependency:
The new dependencies can be removed from the templates.
The pull request also adds new commands to the expressots-cli bin file:
expressots dev
: usests-node-dev
to start the server and watch for changes in the./src
directory and reload, showing type errors.expressots dev --experimental
: usesnodemon
in conjunction withtsc
andeslint
respectively to start the server and watch for changes in the./src
directory and reload and in parallel validate the typing and code style, showing errors.expressots build
: usestsc
that look fortsconfig.build.json
to transpile a hole project in distexpressots build --experimental
: usesconcurrently
to start types, lint and build (with swc) in parallel, and if one of these tasks fail, the process exit code is an errorAny other information that is important to this PR.