Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace /{{ page.lang }}/changelog/4x.html with /en/changelog/ #1685

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from

Conversation

peterdanwan
Copy link

@peterdanwan peterdanwan commented Nov 17, 2024

This PR:

  • changes the link in _includes/header/header-th.html:
    • from: <a href="/{{ page.lang }}/changelog/4x.html">บันทึกการเปลี่ยนแปลง</a>
    • to: <a href="/en/changelog/">บันทึกการเปลี่ยนแปลง</a>
  • changes the link in _includes/header/header-id.html:
    • from: <a href="/{{ page.lang }}/changelog/4x.html">Release Change Log</a>
    • to: <a href="/en/changelog/">Release Change Log</a>
  • adds the css/uz.css file, following the same styles as css/tr.css
  • attempts to close Broken link and missing page #1684

Demonstration of http://localhost:4000/id/ Release Change Log link working:

2024-11-17.15-00-17.mp4

Demonstration of http://localhost:4000/th/ Release Change Log link working:

2024-11-17.15-01-32.mp4

Copy link

netlify bot commented Nov 17, 2024

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit c099619
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/673a6f88158b0200089afc35
😎 Deploy Preview https://deploy-preview-1685--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chrisdel101
Copy link
Contributor

These changes look good to me. Thanks for your contribution!
We'll have a few other members approve it and then it should be good to go.

@peterdanwan
Copy link
Author

These changes look good to me. Thanks for your contribution! We'll have a few other members approve it and then it should be good to go.

My pleasure! If there's anything else regarding this issue, please let me know. I'm happy to try and help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link and missing page
4 participants