-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple social media links to the footer #1667
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
7626358
to
2912e3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love this idea! Thanks @bjohansebas for taking the initiative here ❤️
</a> | ||
</div> | ||
<div> | ||
<a href="https://openjs-foundation.slack.com/archives/C02QB1731FH" aria-label="Go to the repository on Slack">{% include icons/slack.svg %}</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<a href="https://openjs-foundation.slack.com/archives/C02QB1731FH" aria-label="Go to the repository on Slack">{% include icons/slack.svg %}</a> | |
<a href="https://slack-invite.openjsf.org/" aria-label="Go to the repository on Slack">{% include icons/slack.svg %}</a> |
Maybe is better to provide a link to the slack invitation rather than the channel? Ideally we can have a small section in the web where we explain how to join slack and what channels to monitor. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'd prefer them to join the specific Slack channel instead of just Slack itself, as Slack is more general and includes all OpenJSF projects. The idea here is to strengthen Express
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@expressjs/docs-wg, what do you all think about this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @bjohansebas , we should direct to the channel for the express
* improve social media * improve style.css * include in other langs
Express has several social media channels that can be promoted from the website.
cc: @expressjs/express-tc
closes: #1123