Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple social media links to the footer #1667

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Conversation

bjohansebas
Copy link
Member

Express has several social media channels that can be promoted from the website.

cc: @expressjs/express-tc

closes: #1123

@bjohansebas bjohansebas requested a review from a team October 25, 2024 00:07
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 2912e3e
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/671ae689aacb840008f75147
😎 Deploy Preview https://deploy-preview-1667--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bjohansebas bjohansebas removed the request for review from a team October 25, 2024 00:08
@bjohansebas bjohansebas marked this pull request as ready for review October 25, 2024 00:19
@bjohansebas bjohansebas requested a review from a team October 25, 2024 00:19
Copy link
Contributor

@carlosstenzel carlosstenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this idea! Thanks @bjohansebas for taking the initiative here ❤️

</a>
</div>
<div>
<a href="https://openjs-foundation.slack.com/archives/C02QB1731FH" aria-label="Go to the repository on Slack">{% include icons/slack.svg %}</a>
Copy link
Member

@UlisesGascon UlisesGascon Oct 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<a href="https://openjs-foundation.slack.com/archives/C02QB1731FH" aria-label="Go to the repository on Slack">{% include icons/slack.svg %}</a>
<a href="https://slack-invite.openjsf.org/" aria-label="Go to the repository on Slack">{% include icons/slack.svg %}</a>

Maybe is better to provide a link to the slack invitation rather than the channel? Ideally we can have a small section in the web where we explain how to join slack and what channels to monitor. 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we'd prefer them to join the specific Slack channel instead of just Slack itself, as Slack is more general and includes all OpenJSF projects. The idea here is to strengthen Express

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@expressjs/docs-wg, what do you all think about this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @bjohansebas , we should direct to the channel for the express

@bjohansebas bjohansebas merged commit 6923c2e into gh-pages Oct 28, 2024
10 checks passed
@bjohansebas bjohansebas deleted the add-social-icons branch October 28, 2024 20:57
chrisdel101 pushed a commit to chrisdel101/expressjs.com that referenced this pull request Nov 3, 2024
* improve social media

* improve style.css

* include in other langs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Express Youtube Channel and Twitter Visibility
3 participants