Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using pt-br announcement into pt-br index. issue: #1617 #1623

Merged
merged 1 commit into from
Sep 30, 2024
Merged

using pt-br announcement into pt-br index. issue: #1617 #1623

merged 1 commit into from
Sep 30, 2024

Conversation

italojs
Copy link
Contributor

@italojs italojs commented Sep 16, 2024

issue: #1617

changes

  • I am using pt-br announcement in pt-br index.md
  • added a comment explaining why I'm redirecting to "en" doc version

@netlify Netlify
Copy link

netlify bot commented Sep 16, 2024 •
edited
Loading

✅ Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 39128b5
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/66e86c4553af580008013f2a
😎 Deploy Preview https://deploy-preview-1623--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@italojs italojs mentioned this pull request Sep 16, 2024
Closed
bjohansebas
bjohansebas approved these changes Sep 16, 2024
View reviewed changes
Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

carlosstenzel
carlosstenzel approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@carlosstenzel carlosstenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crandmck crandmck self-requested a review September 30, 2024 03:46
crandmck
crandmck approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@crandmck crandmck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The API docs are not translated, but in fact the English 5.x docs are still in progress, so this is accurate.

@crandmck crandmck merged commit 8f9626f into expressjs:gh-pages Sep 30, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crandmck crandmck crandmck approved these changes

@carlosstenzel carlosstenzel carlosstenzel approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@italojs @crandmck @carlosstenzel @bjohansebas