Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest description #1620

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

bjohansebas
Copy link
Member

@bjohansebas bjohansebas commented Sep 15, 2024

Since #1572 was merged into the main branch, the page now supports editing the description metadata, which is important for the page's SEO.

edit: I'm going to open an issue in the future to report that the description needs to be added to the pages

Copy link

netlify bot commented Sep 15, 2024

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit 52aef8b
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/66e6dea325cf8a0008e0a796
😎 Deploy Preview https://deploy-preview-1620--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@chrisdel101
Copy link
Contributor

chrisdel101 commented Sep 16, 2024

We used to have description, at least in development, but it was removed. I'm all for having it, but I do recall it was specifically removed, and not forgotten about. This was for a in template type of thing.
Is this just the meta? Or a template addition too?
What's the point of having it when the page does not display it?

@bjohansebas
Copy link
Member Author

Although the page doesn't display it directly, search engines do use it and show it to users when they search for Express. Also, now when a link is shared on any social media, the description will appear below the title. It may have lesser importance, but it can be improved to make the page a first-class citizen.

This would be a change that adds just one line, and the page infrastructure already supports it, so it wouldn’t hurt to add it. Making this change across all pages would be a long-term task (and of low relevance), but it could be useful for those who want to get started in the project by making these changes.

@bjohansebas bjohansebas requested a review from a team October 17, 2024 00:39
@chrisdel101
Copy link
Contributor

LGTM.

@UlisesGascon UlisesGascon merged commit cab8004 into expressjs:gh-pages Oct 17, 2024
7 of 8 checks passed
@bjohansebas bjohansebas deleted the blog-description branch October 17, 2024 21:02
chrisdel101 pushed a commit to chrisdel101/expressjs.com that referenced this pull request Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants