Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog: security patches for Sep 24 #1607

Merged
merged 22 commits into from
Sep 30, 2024
Merged

blog: security patches for Sep 24 #1607

merged 22 commits into from
Sep 30, 2024
+135 −0

Conversation

UlisesGascon
Copy link
Member

@UlisesGascon UlisesGascon commented Sep 11, 2024 •
edited
Loading

This blog entry should go live on Sept 30 (Monday).

cc: @expressjs/security-wg @expressjs/security-triage

@netlify Netlify
Copy link

netlify bot commented Sep 11, 2024 •
edited
Loading

✅ Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit bcd9dd3
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/66fa8f67c33f3f0008a18d3e
😎 Deploy Preview https://deploy-preview-1607--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@UlisesGascon
Copy link
Member Author

@chrisdel101 I was not able to find this entry in the preview. Maybe is because has a future date? 🤔

@UlisesGascon UlisesGascon self-assigned this Sep 11, 2024
@UlisesGascon
Copy link
Member Author

Hey @lirantal! I will love to get your feedback on the format if possible :)

@chrisdel101
Copy link
Contributor

Your right! I guess we didn't test this enough. I'm not sure why immediately but I'm looking into this!

@chrisdel101
Copy link
Contributor

So yes, it is because it's future dated. If you want to change the file name date to today to preview it, and then once it's done change it back? Just for now?
We'll need to think about how we want to handle this workflow.

rxmarbles
rxmarbles reviewed Sep 11, 2024
View reviewed changes
Copy link

@rxmarbles rxmarbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

wesleytodd
wesleytodd approved these changes Sep 11, 2024
View reviewed changes
_posts/2024-09-30-security-releases.md Outdated Show resolved Hide resolved
_posts/2024-09-30-security-releases.md Outdated Show resolved Hide resolved
_posts/2024-09-30-security-releases.md Outdated Show resolved Hide resolved
_posts/2024-09-30-security-releases.md Outdated Show resolved Hide resolved
_posts/2024-09-30-security-releases.md Outdated Show resolved Hide resolved
lirantal
lirantal reviewed Sep 16, 2024
View reviewed changes
Copy link
Contributor

@lirantal lirantal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran a first pass on the doc.

_posts/2024-09-30-security-releases.md Outdated Show resolved Hide resolved
_posts/2024-09-30-security-releases.md Outdated Show resolved Hide resolved
_posts/2024-09-30-security-releases.md Outdated Show resolved Hide resolved
_posts/2024-09-30-security-releases.md Outdated Show resolved Hide resolved
_posts/2024-09-30-security-releases.md Outdated Show resolved Hide resolved
_posts/2024-09-30-security-releases.md Outdated Show resolved Hide resolved
_posts/2024-09-30-security-releases.md Outdated Show resolved Hide resolved
_posts/2024-09-30-security-releases.md Outdated Show resolved Hide resolved
_posts/2024-09-30-security-releases.md Outdated Show resolved Hide resolved
_posts/2024-09-30-security-releases.md Outdated Show resolved Hide resolved
UlisesGascon and others added 12 commits September 16, 2024 15:03
@UlisesGascon @lirantal
Update _posts/2024-09-30-security-releases.md
f98c2ae 
Co-authored-by: Liran Tal <[email protected]>
@UlisesGascon @lirantal
Update _posts/2024-09-30-security-releases.md
735cf6b 
Co-authored-by: Liran Tal <[email protected]>
@UlisesGascon @lirantal
Update _posts/2024-09-30-security-releases.md
1354be5 
Co-authored-by: Liran Tal <[email protected]>
@UlisesGascon @lirantal
Update _posts/2024-09-30-security-releases.md
7188093 
Co-authored-by: Liran Tal <[email protected]>
@UlisesGascon @lirantal
Update _posts/2024-09-30-security-releases.md
e24bf31 
Co-authored-by: Liran Tal <[email protected]>
@UlisesGascon @lirantal
Update _posts/2024-09-30-security-releases.md
82fc865 
Co-authored-by: Liran Tal <[email protected]>
@UlisesGascon @lirantal
Update _posts/2024-09-30-security-releases.md
13a4f57 
Co-authored-by: Liran Tal <[email protected]>
@UlisesGascon @lirantal
Update _posts/2024-09-30-security-releases.md
aed825d 
Co-authored-by: Liran Tal <[email protected]>
@UlisesGascon @lirantal
Update _posts/2024-09-30-security-releases.md
432dfce 
Co-authored-by: Liran Tal <[email protected]>
@UlisesGascon @lirantal
Update _posts/2024-09-30-security-releases.md
9f536e1 
Co-authored-by: Liran Tal <[email protected]>
@UlisesGascon
Update _posts/2024-09-30-security-releases.md
33bb348
@crandmck
Edits to security patches blog post for 29 Sept
e1c6418
@crandmck
Copy link
Member

crandmck commented Sep 30, 2024 •
edited
Loading

@UlisesGascon I edited the post for grammar, spelling, and formatting. I changed the file name to 9/29 so we can see it in the deploy preview. In your morning it will be 9/30 anyway, but I wanted to be sure the preview looked OK, since I won't be able to work on it on Monday.

This should be good to go.

@UlisesGascon UlisesGascon marked this pull request as ready for review September 30, 2024 10:26
@UlisesGascon
Copy link
Member Author

The last security release expected was added, so this PR is ready for final review. Publication date is expected today.

carpasse
carpasse suggested changes Sep 30, 2024
View reviewed changes
_posts/2024-09-29-security-releases.md Outdated Show resolved Hide resolved
@UlisesGascon UlisesGascon merged commit 046df00 into gh-pages Sep 30, 2024
7 checks passed
@UlisesGascon UlisesGascon deleted the blog/sep-24-sec branch September 30, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lirantal lirantal lirantal left review comments

@rxmarbles rxmarbles rxmarbles left review comments

@bjohansebas bjohansebas bjohansebas left review comments

@wesleytodd wesleytodd wesleytodd approved these changes

@carpasse carpasse carpasse approved these changes

Assignees

@UlisesGascon UlisesGascon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@UlisesGascon @chrisdel101 @crandmck @lirantal @wesleytodd @carpasse @rxmarbles @bjohansebas