Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Added lang variable for guide links #1422

Conversation

SamIsTheFBI
Copy link
Contributor

Fixes #1406

📝 Description

Prepended {{page.lang}} to /guide/... links in the markdown files at _includes/api/en/4x/. So, now the correct language shows up in the links & it leads to the correct documentations.

The following show the changes at https://expressjs.com/en/api.html#res.render

🖼️ Current behavior

image

⚡ New behavior

Now, the correct language shows in the link.

image

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SamIsTheFBI! This will improve a lot the UX for the users 👍

@dougwilson dougwilson force-pushed the bugfix-language-change-in-api-reference branch from 56a0dbf to 2e87474 Compare November 27, 2023 14:59
dougwilson pushed a commit to SamIsTheFBI/expressjs.com that referenced this pull request Nov 27, 2023
@dougwilson dougwilson force-pushed the bugfix-language-change-in-api-reference branch from 4c34d4a to 9393f34 Compare November 27, 2023 15:04
@dougwilson dougwilson force-pushed the bugfix-language-change-in-api-reference branch from 9393f34 to b33766a Compare November 27, 2023 15:09
@dougwilson dougwilson merged commit b33766a into expressjs:gh-pages Nov 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected redirection to Turkish-language page
3 participants