Fix inheritance should not overwrite the methods on res and req with the ones from http.ServerResponse and http.IncomingMessage #6047

Tofandel · 2024-10-13T12:08:00Z

This allows for express to run correctly with unenv and paves the way for it to be used in other envs than node

I also have a backport for 4.x ready

…se and http.IncomingMessage

Tofandel changed the title ~~Fix inheritance should not overwrite the methods res and req with the ones from http.ServerResponse and http.IncomingMessage~~ Fix inheritance should not overwrite the methods on res and req with the ones from http.ServerResponse and http.IncomingMessage Oct 13, 2024

Fix inheritance should not overwrite the methods of http.ServerRespon…

1847da8

…se and http.IncomingMessage

Tofandel force-pushed the master branch from 965d171 to 1847da8 Compare October 13, 2024 14:09

bjohansebas added the require-triage label Oct 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix inheritance should not overwrite the methods on res and req with the ones from http.ServerResponse and http.IncomingMessage #6047

Fix inheritance should not overwrite the methods on res and req with the ones from http.ServerResponse and http.IncomingMessage #6047

Tofandel commented Oct 13, 2024 •

edited

Loading

Fix inheritance should not overwrite the methods on res and req with the ones from http.ServerResponse and http.IncomingMessage #6047

Are you sure you want to change the base?

Fix inheritance should not overwrite the methods on res and req with the ones from http.ServerResponse and http.IncomingMessage #6047

Conversation

Tofandel commented Oct 13, 2024 • edited Loading

Tofandel commented Oct 13, 2024 •

edited

Loading