Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ add discarded middleware test #5819

Merged
merged 1 commit into from
Oct 20, 2024
Merged

✅ add discarded middleware test #5819

merged 1 commit into from
Oct 20, 2024
+50 −0

Conversation

ctcpip
Copy link
Member

@ctcpip ctcpip commented Aug 9, 2024

No description provided.

@wesleytodd
Copy link
Member

Lets not merge anything more to master until we merge 5.x. Just wanted to drop the approval here since I was going through notifications.

UlisesGascon
UlisesGascon approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! but let's wait until we can merge it :)

@UlisesGascon
Copy link
Member

condition meet, I will merge the PR

@UlisesGascon UlisesGascon merged commit 082d6d1 into master Oct 20, 2024
49 checks passed
@UlisesGascon UlisesGascon deleted the use-mw-test branch October 20, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleytodd wesleytodd wesleytodd approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctcpip @wesleytodd @UlisesGascon