Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default setting of query parser from extended to simple #3621

Merged
merged 1 commit into from
Dec 18, 2021
+5 −3
Merged

Change default setting of query parser from extended to simple #3621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions History.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@

This incorporates all changes after 4.17.1 up to 4.17.2.

* change:
- query parser setting defaults to `'simple'`
* deps: [email protected]
- `req.body` is no longer always initialized to `{}`
- `urlencoded` parser now defaults `extended` to `false`
Expand Down
2 changes: 1 addition & 1 deletion lib/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ app.defaultConfiguration = function defaultConfiguration() {
this.enable('x-powered-by');
this.set('etag', 'weak');
this.set('env', env);
this.set('query parser', 'extended');
this.set('query parser', 'simple')
this.set('subdomain offset', 2);
this.set('trust proxy', false);

Expand Down
4 changes: 2 additions & 2 deletions test/req.query.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ describe('req', function(){
.expect(200, '{}', done);
});

it('should default to parse complex keys', function (done) {
it('should default to parse simple keys', function (done) {
var app = createApp();

request(app)
.get('/?user[name]=tj')
.expect(200, '{"user":{"name":"tj"}}', done);
.expect(200, '{"user[name]":"tj"}', done);
});

describe('when "query parser" is extended', function () {
Expand Down