Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callback implementation and tests for write and end #101

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Callback implementation and tests for write and end #101

wants to merge 6 commits into from

Commits on Jan 4, 2017

  1. Callback implementation and tests for write and end. 

    Callbacks will be called on `write` and `end` when supported in nodejs (requires nodejs >= 0.12.x).
Credit goes to @jpodwys for the majority of the implementation.
    @whitingj
    whitingj committed Jan 4, 2017
    Configuration menu
    Copy the full SHA
    a68265e View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2017

  1. Callbacks are only used if nodejs supports callbacks. Updated tests t… 

    …o assert that no callbacks are made for nodejs < 0.12.x
    @whitingj
    whitingj committed Jan 5, 2017
    Configuration menu
    Copy the full SHA
    a7c7615 View commit details
    Browse the repository at this point in the history

  2. Fixing lint error, missing space after “//“

    @whitingj
    whitingj committed Jan 5, 2017
    Configuration menu
    Copy the full SHA
    ce0f02f View commit details
    Browse the repository at this point in the history

  3. Removing the version bump.

    @whitingj
    whitingj committed Jan 5, 2017
    Configuration menu
    Copy the full SHA
    9d55cfd View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2017

  1. Removing the feature detection checks. This PR now assumes that callb… 

    …acks are always supported.
    @whitingj
    whitingj committed Jan 6, 2017
    Configuration menu
    Copy the full SHA
    4a8e87f View commit details
    Browse the repository at this point in the history

  2. Removing conditional checks in unit tests and removing unsupported ve… 

    …rsions of node from .travis.yml.
    @whitingj
    whitingj committed Jan 6, 2017
    Configuration menu
    Copy the full SHA
    2fdf90f View commit details
    Browse the repository at this point in the history