Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[menu-bar] Bump expo SDK to stable release #219

Merged
merged 7 commits into from
Nov 21, 2024

Conversation

gabrieldonadel
Copy link
Member

@gabrieldonadel gabrieldonadel commented Nov 14, 2024

Why

SDK 52 is out and we no longer need to maintain library patches

How

  • Bump expo and react-native-svg versions
  • Fix debug logs in windows
  • Fix tray icon in Linux
  • Remove react-native-svg and expo-module-core patches

Test Plan

Run locally on macOS and Linux

image

@@ -0,0 +1,17 @@
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This allow us to debug the node process directly from vscode

@gabrieldonadel gabrieldonadel changed the title @gabrieldonadel/bump expo [menu-bar] Bump expo SDK to stable release Nov 14, 2024
@gabrieldonadel gabrieldonadel marked this pull request as ready for review November 21, 2024 13:38
@gabrieldonadel gabrieldonadel merged commit 34b39f1 into main Nov 21, 2024
1 check passed
@gabrieldonadel gabrieldonadel deleted the @gabrieldonadel/bump-expo branch November 21, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant