-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add with-router-typescript example #423
base: master
Are you sure you want to change the base?
Conversation
"metro": "^0.73.7", | ||
"metro-resolver": "^0.73.7" | ||
}, | ||
"overrides": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"resolutions"
and "overrides"
are in the original package.json
from with-router
as well:
examples/with-router/package.json
Lines 25 to 32 in bd68019
"resolutions": { | |
"metro": "^0.73.7", | |
"metro-resolver": "^0.73.7" | |
}, | |
"overrides": { | |
"metro": "^0.73.7", | |
"metro-resolver": "^0.73.7" | |
}, |
probably some compatibility thing
Is there any point in this when |
I will say I would greatly appreciate this PR. I love expo-router, and have been having issues trying to implement TypeScript after spinning up |
I already created the application and installed the TS even before starting to use expo-router, is there a way to type the routes? |
There is a discussion about typed props of a route here (originally an issue, but converted into a discussion): |
Add new with router typescript example based on suggestions #412 (comment)