-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-14204][eas-cli] UX improvements for env:list command #2697
base: main
Are you sure you want to change the base?
[ENG-14204][eas-cli] UX improvements for env:list command #2697
Conversation
Size Change: +790 B (0%) Total Size: 52.9 MB
|
Subscribed to pull request
Generated by CodeMention |
❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2697 +/- ##
==========================================
- Coverage 52.96% 52.94% -0.01%
==========================================
Files 576 576
Lines 22095 22097 +2
Branches 4334 4335 +1
==========================================
- Hits 11701 11698 -3
- Misses 10360 10366 +6
+ Partials 34 33 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Why
Currently using the
env:list
command is confusing and annoying with this multi-select for environments and too noisy when an env var is secret or sensitiveHow
Make it less noisy.
Just use select for environment vs multi-select.
Test Plan
Tested it manually