Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-14204][eas-cli] UX improvements for env:list command #2697

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Nov 15, 2024

Why

Currently using the env:list command is confusing and annoying with this multi-select for environments and too noisy when an env var is secret or sensitive

How

Make it less noisy.

Just use select for environment vs multi-select.

Test Plan

Tested it manually

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Nov 15, 2024

Size Change: +790 B (0%)

Total Size: 52.9 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 52.9 MB +790 B (0%)

compressed-size-action

@szdziedzic szdziedzic marked this pull request as ready for review November 15, 2024 15:27
Copy link

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela

Generated by CodeMention

@szdziedzic szdziedzic changed the title [eas-cli] UX improvements for env:list command [ENG-14204][eas-cli] UX improvements for env:list command Nov 15, 2024
Copy link

linear bot commented Nov 15, 2024

Copy link

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 48.71795% with 20 lines in your changes missing coverage. Please review.

Project coverage is 52.94%. Comparing base (fed28a8) to head (befc501).

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/env/list.ts 60.00% 12 Missing ⚠️
packages/eas-cli/src/utils/variableUtils.ts 11.12% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2697      +/-   ##
==========================================
- Coverage   52.96%   52.94%   -0.01%     
==========================================
  Files         576      576              
  Lines       22095    22097       +2     
  Branches     4334     4335       +1     
==========================================
- Hits        11701    11698       -3     
- Misses      10360    10366       +6     
+ Partials       34       33       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@radoslawkrzemien radoslawkrzemien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@szdziedzic szdziedzic marked this pull request as draft November 19, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants