[WIP][do not merge][RFC] feat: support for development provisioning profiles (iOS)

packages/eas-cli/src/build/android/build.ts

@@ -39,10 +39,13 @@ export async function createAndroidContextAsync(
 ): Promise<AndroidBuildContext> {
   const { buildProfile } = ctx;
 
-  if (buildProfile.distribution === 'internal' && buildProfile.gradleCommand?.match(/bundle/)) {
+  if (
+    (buildProfile.distribution === 'internal' || buildProfile.distribution === 'development') &&
+    buildProfile.gradleCommand?.match(/bundle/)
+  ) {
     Log.addNewLineIfNone();
     Log.warn(
-      `You're building your Android app for internal distribution. However, we've detected that the Gradle command you defined (${chalk.underline(
+      `You're building your Android app for internal or development distribution. However, we've detected that the Gradle command you defined (${chalk.underline(
         buildProfile.gradleCommand
       )}) includes string 'bundle'.
 This means that it will most likely produce an AAB and you will not be able to install it on your Android devices straight from the Expo website.`

packages/eas-cli/src/build/android/prepareJob.ts

@@ -48,7 +48,11 @@ export async function prepareJobAsync(
     : {};
 
   let buildType = buildProfile.buildType;
-  if (!buildType && !buildProfile.gradleCommand && buildProfile.distribution === 'internal') {
+  if (
+    !buildType &&
+    !buildProfile.gradleCommand &&
+    (buildProfile.distribution === 'internal' || buildProfile.distribution === 'development')
+  ) {
     buildType = Android.BuildType.APK;
   }
 

packages/eas-cli/src/build/graphql.ts

@@ -82,7 +82,11 @@ function transformCredentialsSource(
 }
 
 function transformDistribution(distribution: Metadata['distribution']): DistributionType {
-  if (distribution === 'internal') {
+  //TODO: remove when change is added upstream to eas-build-job
+  //@ts-ignore
+  if (distribution === 'development') {
+    return DistributionType.Development;
+  } else if (distribution === 'internal') {
     return DistributionType.Internal;
   } else if (distribution === 'simulator') {
     return DistributionType.Simulator;

packages/eas-cli/src/build/metadata.ts

@@ -34,6 +34,8 @@ export async function collectMetadataAsync<T extends Platform>(
     fingerprintSource: runtimeMetadata?.fingerprintSource,
     reactNativeVersion: await getReactNativeVersionAsync(ctx.projectDir),
     ...channelObject,
+    //TODO: needs to be updated in @expo/eas-build-job
+    //@ts-expect-error
     distribution,
     appName: ctx.exp.name,
     appIdentifier: resolveAppIdentifier(ctx),

packages/eas-cli/src/build/types.ts

@@ -15,6 +15,7 @@ export enum BuildStatus {
 }
 
 export enum BuildDistributionType {
+  DEVELOPMENT = 'development',
   STORE = 'store',
   INTERNAL = 'internal',
   /** @deprecated Use simulator flag instead */

packages/eas-cli/src/build/utils/printBuildInfo.ts

@@ -92,7 +92,10 @@ function printBuildResult(build: BuildFragment): void {
     return;
   }
 
-  if (build.distribution === DistributionType.Internal) {
+  if (
+    build.distribution === DistributionType.Internal ||
+    build.distribution === DistributionType.Development
+  ) {
     Log.addNewLineIfNone();
     const logsUrl = getBuildLogsUrl(build);
     // It's tricky to install the .apk file directly on Android so let's fallback

packages/eas-cli/src/commands/build/resign.ts

@@ -297,7 +297,7 @@ export default class BuildResign extends EasCommand {
         json: false,
       },
       filter: {
-        distribution: DistributionType.Internal,
+        distribution: DistributionType.Internal || DistributionType.Development,
         platform: toAppPlatform(platform),
         status: BuildStatus.Finished,
         buildProfile,
@@ -316,8 +316,11 @@ export default class BuildResign extends EasCommand {
   ): Promise<BuildFragment | undefined> {
     if (maybeBuildId) {
       const build = await BuildQuery.byIdAsync(graphqlClient, maybeBuildId);
-      if (build.distribution !== DistributionType.Internal) {
-        throw new Error('This is not an internal distribution build.');
+      if (
+        build.distribution !== DistributionType.Internal &&
+        build.distribution !== DistributionType.Development
+      ) {
+        throw new Error('This is not an internal or development distribution build.');
       }
       if (build.status !== BuildStatus.Finished) {
         throw new Error('Only builds that finished successfully can be re-signed.');

packages/eas-cli/src/credentials/ios/IosCredentialsProvider.ts

@@ -10,7 +10,11 @@ import { getAppFromContextAsync } from './actions/BuildCredentialsUtils';
 import { SetUpBuildCredentials } from './actions/SetUpBuildCredentials';
 import { SetUpPushKey } from './actions/SetUpPushKey';
 import { App, IosCredentials, Target } from './types';
-import { isAdHocProfile, isEnterpriseUniversalProfile } from './utils/provisioningProfile';
+import {
+  isAdHocProfile,
+  isDevelopmentProfile,
+  isEnterpriseUniversalProfile,
+} from './utils/provisioningProfile';
 import { CommonIosAppCredentialsFragment } from '../../graphql/generated';
 import Log from '../../log';
 import { findApplicationTarget } from '../../project/ios/target';
@@ -36,10 +40,7 @@ enum PushNotificationSetupOption {
 export default class IosCredentialsProvider {
   public readonly platform = Platform.IOS;
 
-  constructor(
-    private readonly ctx: CredentialsContext,
-    private readonly options: Options
-  ) {}
+  constructor(private readonly ctx: CredentialsContext, private readonly options: Options) {}
 
   public async getCredentialsAsync(
     src: CredentialsSource.LOCAL | CredentialsSource.REMOTE
@@ -153,6 +154,18 @@ export default class IosCredentialsProvider {
   private assertProvisioningProfileType(provisioningProfile: string, targetName?: string): void {
     const isAdHoc = isAdHocProfile(provisioningProfile);
     const isEnterprise = isEnterpriseUniversalProfile(provisioningProfile);
+    const isDevelopment = isDevelopmentProfile(provisioningProfile);
+
+    if (this.options.distribution === 'development') {
+      if (!isDevelopment) {
+        throw new Error(
+          `You must use a development provisioning profile${
+            targetName ? ` (target '${targetName})'` : ''
+          } for development distribution.`
+        );
+      }
+    }
+
     if (this.options.distribution === 'internal') {
       if (this.options.enterpriseProvisioning === 'universal' && !isEnterprise) {
         throw new Error(