Allow multiple recipients within single PushMessage #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -401,6 +412,9 @@ def publish(self, push_message): | |||
| Returns: | |||
| A PushTicket object which contains the results. | |||
| """ | |||
| if isinstance(push_message.to, list) and len(push_message.to) > 1: | |||
| raise ValueError("Sending notification to multiple recipients is not allowed \ | |||
| with publish method. Use publish_multiple method instead.") | |||
There was a problem hiding this comment.
you opted to just not allow it?
Is it easy enough to implement?
| @@ -414,6 +428,9 @@ def publish_multiple(self, push_messages): | |||
| """ | |||
| push_tickets = [] | |||
| for start in itertools.count(0, self.max_message_count): | |||
| # Todo : Check if len(push_message.to) check is required here as well | |||
There was a problem hiding this comment.
From reading the docs it looks like it's 100 total (including the different ones, or same one with multiple "to's"
|
Status on this? This seems usefeul, given the api allows for multiple recipients, and this is just removing some validation safeguards? Why not just remove that sanity check? |
|
Is this pull request going to be merged? It will be useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Idea is to reduce number of network calls when single message is sent to multiple recipients.
Basically, condensing multiple messages into one single push message.
Related Issue : #52