Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for weasel #200

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Conversation

adrianeboyd
Copy link
Contributor

Description

Updates for weasel.

Types of change

?

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • I ran the update scripts in the .github folder, and all the configs and docs are up-to-date.

@adrianeboyd
Copy link
Contributor Author

I think main problem here is that running the whole test suite at once can be too much for the GHA agent (and I think more tests are run in linux than in windows).

I ran the internal weekly tests on this branch and it passed.

Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for updating all of these! Only had a small nitpick question.

And yea, I can see how the CI chokes on wanting to run all of these projects :/ We also don't want this to be dozens of separate PRs, so I think we might just have to merge it being red (😳)

benchmarks/healthsea_spancat/README.md Show resolved Hide resolved
@svlandeg svlandeg merged commit 782da3a into explosion:v3 Nov 9, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants