Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Explainer edits + initial spec. #1

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Conversation

alexnj
Copy link
Collaborator

@alexnj alexnj commented Aug 21, 2024

@alexnj alexnj requested a review from domenic August 21, 2024 02:44
README.md Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
Copy link

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few "Optional auto-linking suggestion"s. They may or may not work; if they don't work then keep doing what you're doing.

(Details: if a term is exported for use in other specs, you can use [=autolinking syntax=]; see https://speced.github.io/bikeshed/#autolinking. If it's not, you can force a reference to it anyway by using the more awkward <a spec=SPECIDENTIFIER>term</a> syntax. The benefits of these over normal links are minor. For example they cause the term to show up in the index. I made educated guesses about which terms are exported vs. not, and exactly how, but if my guesses are wrong then don't worry about getting it exactly right.)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
@alexnj
Copy link
Collaborator Author

alexnj commented Aug 22, 2024

Thanks @domenic for the review! Aside from two crosslinks that didnt work every other suggestion crosslinked appropriately. Updated the PR with the feedback, PTAL!

Copy link

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

index.bs Outdated Show resolved Hide resolved
@alexnj alexnj merged commit cf67dad into explainers-by-googlers:main Aug 22, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Aug 22, 2024
SHA: cf67dad
Reason: push, by alexnj

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants