Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles/update landing page #39

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Styles/update landing page #39

wants to merge 14 commits into from

Conversation

willflemmer
Copy link

@willflemmer willflemmer commented Sep 12, 2021

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Please mark relevant issues as closed/resolved here.

Please include a screenshot of relevant change if helpful.

Type of change

Please delete options that are not relevant.

  • Bug fix
  • New feature
  • Refactor
  • Documentation

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Developer Tools
  • Cypress
  • CI

@drakep
Copy link

drakep commented Sep 12, 2021

Is it intentional the count down doesn't show if one is set?

@willflemmer
Copy link
Author

Yes, it wasn't in the other website.

@levicook
Copy link
Contributor

Reviewing now!

@levicook
Copy link
Contributor

Would you mind posting screenshots so I can see what the end result is? I was about to clone & run this, but realized I'm incredibly tight on time. Also keep in mind the goal of this project is to be maximally bland + easy to modify. The goal of fork and modify is a primary goal of the overall project, so I don't want people to unwind too much.

@willflemmer
Copy link
Author

Sure, here's the screenshot:
image
Let me know if there's any changes you'd like.

@levicook
Copy link
Contributor

Sure, here's the screenshot:
image
Let me know if there's any changes you'd like.

This looks great, but I don't want to feature a specific project. Would you mind turning this into something more generic with placeholders?

(And full transparency, I've used this to launch other projects & kept their brands out of it too :))

@willflemmer
Copy link
Author

Sure, here's the screenshot:
image
Let me know if there's any changes you'd like.

This looks great, but I don't want to feature a specific project. Would you mind turning this into something more generic with placeholders?

(And full transparency, I've used this to launch other projects & kept their brands out of it too :))

Sure, I'll just place generic images and text.

If you want I can make a file which you just enter the relevant text and images and then it generates the react code for you?

@willflemmer
Copy link
Author

image

@ohaddahan
Copy link

@willflemmer when running yarn build or yarn start.

candy-machine-mint/src/Home.tsx
TypeScript error in candy-machine-mint/src/Home.tsx(172,9):
Object is possibly 'undefined'.  TS2532

@willflemmer
Copy link
Author

@willflemmer when running yarn build or yarn start.

candy-machine-mint/src/Home.tsx
TypeScript error in candy-machine-mint/src/Home.tsx(172,9):
Object is possibly 'undefined'.  TS2532

Should be fixed now. Let me know if there's anything else

@ohaddahan
Copy link

@willflemmer , ConnectButton doesn't render since wallet is falsey.

@willflemmer
Copy link
Author

@ohaddahan buttons now display correctly.

@ohaddahan
Copy link

@willflemmer works, thanks!

@saraspaudel
Copy link

After connecting the wallet to an empty candy machine, the "Sold Out" message flashes quickly and disappears. I had to refresh the page to see that.

@saraspaudel
Copy link

Extra gap in navbar

Screen Shot 2021-09-26 at 9 36 16 PM

@ohaddahan ohaddahan mentioned this pull request Sep 30, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants