Update localstack and opensearch #5824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ErikSchierboom Can you check you're happy with this please. |
iHiD
commented
Jul 31, 2023
Gemfile
Outdated
| @@ -37,7 +37,7 @@ gem 'kaminari' | |||
| gem 'oj', '~> 3.14.0' | |||
|
|
|||
| # Setup dependencies | |||
| gem 'exercism-config', '>= 0.106.0' | |||
| gem 'exercism-config', '>= 0.107.0.beta1' | |||
There was a problem hiding this comment.
We need to release an actual config gem and update this before merging,
iHiD
commented
Jul 31, 2023
| @@ -69,7 +69,7 @@ We use localstack and opensearch, and run them via Docker. | |||
|
|
|||
| ```bash | |||
| docker run -dp 3042:8080 -p 3040:4566 -p 3041:4566 localstack/localstack | |||
| docker run -dp 9200:9200 -e "discovery.type=single-node" opensearchproject/opensearch:1.1.0 | |||
| docker run -dp 9200:9200 -e "discovery.type=single-node" opensearchproject/opensearch:2.9.0 | |||
There was a problem hiding this comment.
Maybe we save these versions somewhere so that they're consistent in dev + ci?
There was a problem hiding this comment.
Done in 57ac597
Looks to be working: https://github.com/exercism/website/actions/runs/5724277008/job/15510467895
ErikSchierboom
force-pushed
the
new-ci-versions
branch
2 times, most recently
from
1cd61fa
to
57ac597
Compare
iHiD
commented
Aug 1, 2023
| docker run -dp 3042:8080 -p 3040:4566 -p 3041:4566 localstack/localstack:2.2.0 | ||
| docker run -dp 9200:9200 -e "discovery.type=single-node" opensearchproject/opensearch:2.9.0 | ||
| docker run -dp 3042:8080 -p 3040:4566 -p 3041:4566 $(jq -r '.localstack' .dockerimages.json) | ||
| docker run -dp 9200:9200 -e "discovery.type=single-node" $(jq -r '.opensearch' .dockerimages.json) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.