Approaches for Atbash Cipher

[safwansamsudeen]

No description provided.

[BethanyG]

Hi @safwansamsudeen - Thanks for submitting this! Overall, it reads pretty well, but I am going to need to you change all the single letter variable names to something more readable in your code examples -- our track style is no single letter variable names - not even in comprehensions. Thanks for understanding. 🙂

[safwansamsudeen]

Hey sorry for the delay. Is i for index in loops allowed?

[BethanyG]

Hey sorry for the delay. Is i for index in loops allowed?

Nope. We are super-duper pendantic/conservative about it. index, item, member, etc.

[BethanyG]

CI is broken at the moment. Trying to get it fixed without having to regenerate all the test files again, but I might have to anyways.

[safwansamsudeen]

Nope. We are super-duper pendantic/conservative about it.
As you wish ;).

I've also added a link to a Programiz article explaining maketrans, based on a student request.

[safwansamsudeen]

@BethanyG could we merge?

[BethanyG]

There's a couple of places where the variable names were single letters. Beyond that, looks good.