Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synced instructions.md & introduction.md Files from Problem Specifications #3423

Merged

Conversation

BethanyG
Copy link
Member

Synced the introduction.md and instruction.md files for the following exercises:

  • accumulate
  • binary
  • binary-search
  • book-store
  • bowling
  • darts
  • error-handling
  • gigasecond
  • hexadecimal
  • killer-sudoku-helper
  • linked-list
  • nucleotide-count
  • octal
  • pangram
  • parallel-letter-frequency
  • queen-attack
  • roman-numerals
  • saddle-points
  • secret-handshake
  • sieve
  • strain
  • sum-of-multiples
  • trinary
  • two-fer

@ErikSchierboom
Copy link
Member

I'm holding off on approving as this will have the same issue mentioned in #3373 (comment)

@BethanyG
Copy link
Member Author

BethanyG commented May 19, 2023

It will?!!? AFAK, none of these include re-generated test files -- these are all problem descriptions and introductions which shouldn't trigger any re-submissions, unless I am misunderstanding things.

@BethanyG
Copy link
Member Author

I'll put a hold label on this, though. 😄

@BethanyG BethanyG added the do not merge 🚧 Don't merge until this label is removed. label May 19, 2023
@ErikSchierboom
Copy link
Member

@BethanyG I'll double check when I have some time!

@BethanyG
Copy link
Member Author

BethanyG commented Jun 5, 2023

@ErikSchierboom - Another nudge. 😄

These are updates to instruction documentation only - not tests or test data. For example, the change referred to here on the forum. I can't think of a scenario where they'd create solution re-queue.

If it helps, I can break each out into its own PR -- although that feels excessive for problem-spec updates.

Just let me know - thanks!

@ErikSchierboom
Copy link
Member

@BethanyG I'm sorry, but I am totally swamped by getting everything related to payments and Exercism Premium done.

@ErikSchierboom
Copy link
Member

giphy

@iHiD
Copy link
Member

iHiD commented Jul 14, 2023

It will?!!? AFAK, none of these include re-generated test files -- these are all problem descriptions and introductions which shouldn't trigger any re-submissions, unless I am misunderstanding things.

To be clear, until these latest changes docs would trigger reruns as they're included in the important files, which are what we use as our flag (ie they tell students they need to update). However, we've now refined the logic so it doesn't include docs.

@BethanyG
Copy link
Member Author

BethanyG commented Jul 14, 2023

Wow. Thank you thank you both for all the work put in to fix and test this!!
I will never look at something as "just a sync" again! 🙀

❤️ 🧡 💛 💚 💙 💜

@BethanyG BethanyG removed the do not merge 🚧 Don't merge until this label is removed. label Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants