Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded curl install and remove commands #115

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Remove unneeded curl install and remove commands #115

merged 1 commit into from
Oct 31, 2023

Conversation

ErikSchierboom
Copy link
Member

No description provided.

ErikSchierboom
ErikSchierboom commented Oct 31, 2023
View reviewed changes
Dockerfile
Comment on lines -8 to -9
&& apt-get install curl -y \
&& apt-get remove curl -y \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the purpose was of installing and then removing curl, but the golden tests pass without these lines.

Copy link
Member

@BethanyG BethanyG Oct 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch! I think I cargo-culted these from a prior version. 😅

BethanyG
BethanyG approved these changes Oct 31, 2023
View reviewed changes
Dockerfile
Comment on lines -8 to -9
&& apt-get install curl -y \
&& apt-get remove curl -y \
Copy link
Member

@BethanyG BethanyG Oct 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch! I think I cargo-culted these from a prior version. 😅

@BethanyG
Copy link
Member

BethanyG commented Oct 31, 2023 •
edited
Loading

I am going to wait to merge this and the other PR until I have finished updating all the concept test files to account for me removing subtest data from the test headline. I am hoping to be done sometime today (PST), and can then merge them all in.

Actually, this is an edit to the existing buster-slim build, so I may as well adjust it. Although once #114 is merged, the same change will happen, and we'll switch to Alpine.

@BethanyG BethanyG merged commit 90aed1c into main Oct 31, 2023
2 checks passed
@BethanyG BethanyG deleted the remove-unneeded-command branch October 31, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BethanyG BethanyG BethanyG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ErikSchierboom @BethanyG