Dominoes: Add test case #2151
Open
Dominoes: Add test case #2151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new test case for certain solutions that would satisfy all previous tests but would still be wrong
|
Hi @zeltbrennt, Thanks for opening this. Changed the wording on the PR description from "Resolves " to "Related ". With "resolves" that would cause the issue on the Java track to close when this PR is merged. We don't necessarily want that because after the PR is approved here we still need one in the Java track to update the Java tests and then you can close the issue there. I'll let people more familiar with problem specs do the actual review on this one. |
|
Is there a forum discussion for this issue where the proposed change was discussed and given a go-ahead? |
I think this was created before the forum. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new test case for certain solutions that would satisfy all previous tests but would still be wrong.
Related exercism/java#2196