Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(say): remove misleading comment #910

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

ahans
Copy link
Contributor

@ahans ahans commented Oct 8, 2024

I think a student could be very confused by this comment when we expect them to throw in case of an error. This comment is verbatim copy from the problem specification. At the very least, it should be reworded to make clear that we expect an exception, but I think it's best removed.

[no important files changed]

[no important files changed]
Copy link
Contributor

github-actions bot commented Oct 8, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@ahans
Copy link
Contributor Author

ahans commented Oct 8, 2024

[no important files changed]

@ahans
Copy link
Contributor Author

ahans commented Oct 8, 2024

@vaeng What do you think?

Copy link
Contributor

@vaeng vaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is not necessary with our implementation

@ahans ahans merged commit e74c99e into main Oct 9, 2024
12 checks passed
@ahans ahans deleted the remove_misleading_comment_from_say_test branch October 9, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants