Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Phone-Number Test cases ( tests.toml & phone_number_test.cpp) #867

Closed
wants to merge 2 commits into from

Conversation

tanno1
Copy link
Contributor

@tanno1 tanno1 commented May 6, 2024

first PR here.

used configlet to update tests.toml for phone numbers against the problem-specifications reqs, then went through problem-specs repo, tests.toml, and phone_number_test.cpp and updated cases accordingly to include the correct cases.

Copy link
Contributor

github-actions bot commented May 6, 2024

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this May 6, 2024
@tanno1 tanno1 mentioned this pull request May 6, 2024
21 tasks
@tanno1
Copy link
Contributor Author

tanno1 commented May 9, 2024

Just realized I need to make some updates in the TEST_CASE() function and add in the UUIDs. I looked through previously merged commits and saw that. I will update and re pr tonight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant