Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

high_scores.h: #include <array> #733

Merged
merged 1 commit into from
Nov 3, 2023
Merged

high_scores.h: #include <array> #733

merged 1 commit into from
Nov 3, 2023

Conversation

EQt
Copy link
Contributor

@EQt EQt commented Oct 31, 2023

No need to #include <array>

[no important files changed]

@github-actions
Copy link
Contributor

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Oct 31, 2023
@vaeng vaeng reopened this Nov 2, 2023
@vaeng
Copy link
Contributor

vaeng commented Nov 2, 2023

Thanks for the catch. Would you please include https://github.com/exercism/cpp/blob/main/exercises/practice/high-scores/.meta/example.h as well?

No need to `#include <array>`
Copy link
Contributor

@vaeng vaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vaeng
Copy link
Contributor

vaeng commented Nov 2, 2023

We should be careful to add [no important files changed] in the PR, so that the tests are not re-run

@vaeng vaeng merged commit 2f47f1a into exercism:main Nov 3, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants