feat: Include list of image layer directories in ContainerInfo
#294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadorovsky
force-pushed
the
vadorovsky/docker-rootfs
branch
from
e541969
to
2774c52
Compare
banditopazzo
requested changes
Jun 18, 2024
vadorovsky
force-pushed
the
vadorovsky/docker-rootfs
branch
from
e441688
to
2e214b5
Compare
vadorovsky
force-pushed
the
vadorovsky/docker-openrc
branch
from
0d4ad17
to
c8285c5
Compare
vadorovsky
force-pushed
the
vadorovsky/docker-openrc
branch
2 times, most recently
from
92015b8
to
871258e
Compare
vadorovsky
force-pushed
the
vadorovsky/docker-rootfs
branch
2 times, most recently
from
1fff278
to
4c2933f
Compare
vadorovsky
force-pushed
the
vadorovsky/docker-rootfs
branch
from
4c2933f
to
85e2c82
Compare
banditopazzo
requested changes
Jul 2, 2024
For each container, try to retrieve information about image layers paths (from the host filesystem's perspective) and include them in `ContainerInfo`.
This field is present only for OverlayFS driver. BTRFS doesn not use it.
The procedure for BTRFS is more complicated than for OverlayFS. `GraphDriver` doesn't contain straightforward information. Instead, it has to be retrieved with the following steps: 1. Using the given image ID, find an "imagedb entry". It's located in `/var/lib/docker/image/btrfs/imagedb/content/sha256/<image_id>`. 2. Get the list of layer checksums from that entry. 3. For each layer, check whether a "layerdb entry" exists. It's located in `/var/lib/docker/image/btrfs/layerdb/sha256/<layer_id>`. The layerdb directory contains a `cache-id` file. 4. That `cache-id` file contains an ID of a BTRFS subvolume. The subvolume can be found in `/var/lib/docker/btrfs/subvolumes/<cache_id>`.
vadorovsky
force-pushed
the
vadorovsky/docker-rootfs
branch
from
8a3636a
to
cb77d17
Compare
banditopazzo
requested changes
Sep 4, 2024
Comment on lines
310
to
311
| // TODO(vadorovsky): Parse layer information in Podman. | ||
| layers: Vec::new(), |
There was a problem hiding this comment.
what happened to the previous changes of #309 ?
There was a problem hiding this comment.
I must've done a wrong git push -f. I restored them now, sorry.
Use libpod's image store and layer store to determine image layer directories on the host for Podman.
banditopazzo
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each container, try to retrieve information about image layers paths (from the host filesystem's perspective) and include them in
ContainerInfo.