-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: review of docs, minor maintenance, and bug fix #105
Conversation
@agoose77 from my reading of |
I think the proper fix is to replace what |
Thanks @agoose77 I can't find any instances of Reading https://www.sphinx-doc.org/en/master/extdev/domainapi.html#sphinx.domains.Domain.resolve_any_xref it seems that it is an old method that is only used when a request is coming from an any role (with unknown type). I saw that |
@mmcky ah, my mistake -- it's |
No worries @agoose77 I can't find any methods for https://github.com/search?q=repo%3Aexecutablebooks%2FMyST-Parser%20resolve_any_xref&type=code |
Sorry @mmcky - I'm between things today. Here's a hard link that should clarify whatever the correct thing is! |
thanks @agoose77. I have implemented method forwarding similarly to |
@mmcky thanks for being so patient - been in transit for scipy. Will take a look tomorrow, but honestly merge it if you're happy. It looked reasonable to me last I checked in. |
Thanks @agoose77 I will merge this. It is passing tests so I'm happy with it but we can loop around and make improvements if required. Look forward to hearing about SciPy. |
This PR
tox.ini
and removesTODO
as captured in issues)resolve_any_xref
warning issued bymyst parser
(fixes BUG: sphinx proof is generating warnings #97)