-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: move to Flit build backend #98
Conversation
Thanks for submitting your first pull request! You are awesome! 🤗 |
@mmcky do you have any spare cycles to look at merging this? 😄 |
@agoose77 Super Sorry - this completely escaped my radar. I'll try and loop around to this soon. I'm not super familiar with flit but I'll give it a go. |
At this point, I'd want to use Hatch; flit is increasingly looking to be the build-backend with zero dependencies as its selling point, rather than features. That is to say, there've been suggestions that flit-core's main use case will be underpinning all of the other PEP 517 build backends; repackagers can't use existing wheels, so they need to build everything from a single root build tool. I started with Hatch here: 400c4a2 We'd need to rebase this PR, but I can do that if needs be! |
just curious, why do you need features here though? This is a pure python package, so why complicate things? |
@chrisjsewell not so much a need for features (particular not this repo!), but my guess is that I'm not hugely fussed here; if we don't want to make any inconsistencies at this juncture, we can pursue |
I very much doubt that will be the case, and I haven't seen anything to suggest it. Is there somewhere that states this? |
Not fussed what you choose here really, but yeh I disagree with this, unless as mentioned there is something I am missing with regard to the flit roadmap |
There are ongoing discussions about packaging over on the Discourse for Python. The first mention of this philosophical shift was here, but I've seen other comments scattered around IIRC. |
Honestly I have not fully absorbed the move to Thanks @agoose77 for the update on alternatives. I will have a quick read about |
It's not a huge deal; as long as we're using a PEP 621-supporting backend, then it's not too tricky to change things at a later date ;) |
This means we can remove the setuptools dependency and move onto modern packaging tools.
395bed0
to
3c70c3c
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
=======================================
Coverage 93.21% 93.21%
=======================================
Files 4 4
Lines 398 398
=======================================
Hits 371 371
Misses 27 27
Flags with carried forward coverage won't be shown. Click here to find out more.
|
In order to unblock main and reflect our changing maintenance schedules, I'm merging this as part of restoring CI. |
This PR removes setuptools as our build backend in favour of Flit. This means we can move to using only
pyproject.toml
for all of our build information, and allows us to use modern packaging tools.NB This started out as a PR to use hatchling (hatch), but I moved to Flit to align with existing tools.